Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade scraper (Python conventions, Python version and dependencies) #96

Merged
merged 8 commits into from
Mar 2, 2024

Conversation

benoit74
Copy link
Collaborator

@benoit74 benoit74 commented Feb 29, 2024

Fix #92

Changes:

  • Python 3.12
  • Upgrade + Pin Python dependencies
  • Title is now a constant from the code instead of sourced from live website, in order to match the 30 chars limit
  • Description and Long Description are automatically sourced from live website and match openZIM convention
  • Very significant rearrangement of code architecture to enhance typing / get rid of the Global class
  • All type issues have been fixed (in basic mode)

@benoit74 benoit74 self-assigned this Feb 29, 2024
Copy link

codecov bot commented Feb 29, 2024

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@benoit74 benoit74 changed the title Migrate scraper to new Python conventions Upgrade scraper (Python conventions, Python version and dependencies) Mar 2, 2024
@benoit74 benoit74 merged commit 1983d98 into main Mar 2, 2024
7 checks passed
@benoit74 benoit74 deleted the migrate_to_conventions branch March 2, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade python-scraperlib to 3.x, including CLI support for description / long_description flags
1 participant